bugfix: check callback to avoid std::bad_function_call exception #456
Conversation
|
hi, @zliang-min Thanks for PR, can you add a unit test to cover this? |
BewareMyPower
left a comment
BewareMyPower
left a comment
There was a problem hiding this comment.
Please fix the code style check. See https://github.com/apache/pulsar-client-cpp?tab=readme-ov-file#requirements-for-contributors for how to use clang-format 11 to format the code
| protected: | ||
| bool isMultiTopic_ = GetParam(); | ||
| std::string fullTopicName(const std::string & topicName) { | ||
| return (isNonPersistentTopic ? "non-" : "") + "persistent://public/default/" + topicName; |
There was a problem hiding this comment.
| return (isNonPersistentTopic ? "non-" : "") + "persistent://public/default/" + topicName; | |
| return std::string(isNonPersistentTopic ? "non-" : "") + "persistent://public/default/" + topicName; |
Only std::string can be used to call operator+. Otherwise the build will fail with "Invalid operands to binary expression ('const char *' and 'const char[29]') "
|
|
||
| protected: | ||
| bool isMultiTopic_ = GetParam(); | ||
| std::string fullTopicName(const std::string & topicName) { |
There was a problem hiding this comment.
testPartitionIndex uses TEST but not TEST_F or TEST_P. If you're going to call this method in those tests, please change TEST to TEST_P
|
I will start the release for 3.7.0 soon. Any chance to address the comments? If not, I can open another PR to fix it. |
Hi @BewareMyPower sorry for the late response. I have been busy with some other work recently. You are more than welcome to open another PR for this. Or it will take a little while before I can get back to this. Thanks! |
3 participants
Fixes #455
Motivation
Fixed the bug that when reading messages from a non-persistent topic with
Reader, it throwstd::bad_function_callexception.Modifications
Check
checkbackbefore calling it inAckGroupingTracker.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
A simple bug fix.
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)